Repository navigation
Rebuild grid extraction using shared UI and canonical helpers - #2536
michielbdejong wants to merge 5 commits into
Conversation
|
The nine legacy mixed PRs have been structurally separated and their move-only parents are now ready for trekmeester’s content review.
For every pair, the improvement child includes the move parent in its ancestry and its complete Git tree was verified identical to the original mixed head. The original mixed PRs are closed as superseded, with original branches and review history retained. All 18 replacement heads had green dedicated Table package and Flutter checks at this audit; individual descriptions record the prior local checks. Reviewable does not mean merge-ready. Each pair deliberately retains its legacy base so the move-versus-improvement boundary is reviewable. The move parents still inherit older state-management work and must be restacked onto the clean extraction and pass full Main integration before merging. They are not prerequisites of #2535/#2536 in their current form. Improvement children are separate follow-ups; their review and validation proceeds independently. No merges or speculative reviewer requests were made. Whole-TablePage orchestration/renderers remain unextracted, ELFA’s submodule pin remains unchanged, and persistence/binding semantics are tracked separately in #2538. |
|
Clean-base restack review map (18 November):
The independent CI policy #2497 is also restacked on #2536 ( Each original move head was published under Remaining blockers: full Main CI must complete; #2543 still depends on missing query/configuration APIs and is excluded. The earlier nine-pair inventory was not exhaustive: some other legacy controls also mix recovery/validation/lifecycle changes, so they need baseline audits and separation rather than a blind rebase. The query/result-boundary work and whole-TablePage extraction remain paused; ELFA's pin is unchanged. The detailed inventory, preservation rules and LOC scope are in the batch plan. Trekmeester owns review/merging. |
|
ELFA pin compatibility is now documented in database-apps #121, with a reproducible source-import gate and migration checklist. At ELFA main The audit is preparation only: it changes no ELFA application code, package dependency, lockfile or submodule pointer. We must not treat the clean package's green CI as proof that it is a drop-in replacement for ELFA's current pin, nor copy the whole deferred state framework back just to satisfy the import list. Actual adaptation, fresh UI/file-package setup and NextGraph type/build/browser parity gates remain open. |
Ready for trekmeester's review as a bounded extraction foundation. Full Main CI is still a merge prerequisite. The fresh manually dispatched run is https://github.com/ontola/atomic-server/actions/runs/44264955689; runner selection passed, but the self-hosted Main and downstream jobs are queued. Dedicated checks were green at code head
cbaa6c1; the latest221d161commit updates the review plan only, with no runtime changes. Combined code verification is recorded in batchbd4fa0e, whose Table and Shared UI lanes pass; full Main CI remains pending. The incomplete whole-TablePage port is separate follow-up scope, not a claim of this PR. No merge will be performed by this worker.The original grid extraction copied UI helpers and was followed by a mixed stack of extraction and functionality changes. Rebuild its code-move foundation on #2535, preserving existing Atomic behavior and using the same
@tomic/uiimplementations as the rest of the Data Browser.Move the existing grid, selection/keyboard/clipboard code and primitive cell editors into private
@tomic/table; leave compatibility exports and the existing Atomic display/host adapters. Move EventManager and civil-date helpers into one dependency-free private build input,@tomic/utils. SDK and UI distributions include the compiled helpers, so SDK consumers gain no React dependency or private runtime dependency. Consume table/UI from the pinned submodule; no npm publication is needed.This adds 304 net frontend production lines relative to #2535 (513 across both clean foundation PRs), excluding tests, scripts, declarations and configuration. Existing keyboard/editor state ownership is retained. Optional host-owned raw-text drafts, saved-view controllers, write queues/receipts, retries and changed validation are deferred. The complete existing TableViewTabs stays in the host until it moves with the complete page.
This is preparation, not the completed TablePage port. The page orchestration, built-in alternate renderers and remaining shared controls still need extraction. The ELFA submodule pin and native app are unchanged; record-editor/resource binding design is a separate discussion. This branch replaces the grid foundation in #2434 without rewriting that branch or its descendants. All nine legacy mixed PRs now have structural move/improvement splits; the originals are closed with history preserved. Those replacement pairs still retain legacy ancestry. Move-only restacking onto this clean foundation is now underway; improvements remain separate and require their own subsequent restacking. The current inventory is in
planning/tablepage-extraction-reset.md.Validation:
@tomic/utilsinstalled./workspace/artifacts/table-extraction-only; desktop/mobile screenshots were shown in the task chat.Add an independent Table package CI lane with packed-consumer validation; retain full app integration in Main CI. Full CI remains outstanding; remaining whole-page extraction is tracked separately.
Tracks #2484 and the agreed response to Joep.